feat(python, rust): new n_chars
functionality for utf8 strings
#5252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5249.
The linked issue raises a good point; we're currently returning
nbytes
rather than what most people (and python) would consider to be the "actual" string length, and offering no function for getting that length. However, gettingnbytes
has value (and is faster).So, this PR separates the two concepts into
str.lengths
andstr.n_bytes
, to offer the "expected" and the existing functionality (in a more unambiguous form; you can opt to usen_bytes
when you know you're only dealing with ascii, for example):Updated:
str.lengths
remains unchanged (non-breaking for existing code).str.n_chars
(new) now provides the character-count functionality.Example: