-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): Add newline to Aggregate..FROM describe_optimization_plan #5253
Conversation
Thanks! It is almost there. We should only keep the indentation level. |
Now returns this:
|
} => write!(f, "Aggregate\n\t{:?} BY {:?} FROM {:?}", aggs, keys, input), | ||
} => write!( | ||
f, | ||
"Aggregate\n\t{:?} BY {:?} FROM\n\t{:?}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an indent
argument that should be used. See the other nodes.
The indentation changes when we get deeper in the query.
Does this look ok? Output:
|
} => { | ||
writeln!( | ||
f, | ||
"{:indent$}Aggregate\n\t{:?} BY {:?} FROM", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the first indentation is correct. But then there is a new line followed by a tab, e.g. \n\t
that should also be indented by {:indent}
instead of the tab.
"{:indent$}Aggregate\n{:indent}{:?} BY {:?} FROM",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh yes sorry I completely missed that one. Think I've addressed this now.
That's it! Thanks. |
Now returns:
Closes #5208