Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust, python): Correct CSV row indexing #5385

Merged
merged 6 commits into from
Oct 31, 2022
Merged

fix(rust, python): Correct CSV row indexing #5385

merged 6 commits into from
Oct 31, 2022

Conversation

owrior
Copy link
Contributor

@owrior owrior commented Oct 31, 2022 •
edited
Loading

@owrior owrior changed the title Correct CSV row position bug[rust]:Correct CSV row position Oct 31, 2022
@owrior owrior changed the title bug[rust]:Correct CSV row position bug(rust):Correct CSV row position Oct 31, 2022
@owrior owrior changed the title bug(rust):Correct CSV row position bug(rust): Correct CSV row position Oct 31, 2022
@owrior owrior changed the title bug(rust): Correct CSV row position bug(rust): Correct CSV row indexing Oct 31, 2022
ritchie46
ritchie46 reviewed Oct 31, 2022
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have one suggestion for the test, otherwise good to go.

py-polars/tests/unit/io/test_csv.py Outdated Show resolved Hide resolved
@ritchie46 ritchie46 changed the title bug(rust): Correct CSV row indexing fix(rust, python): Correct CSV row indexing Oct 31, 2022
@ritchie46 ritchie46 merged commit 4dd178b into pola-rs:master Oct 31, 2022
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 31, 2022
@owrior owrior deleted the csv-row-count-fix branch October 31, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 left review comments

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

withRowCount() seems to reset its output
2 participants
@owrior @ritchie46