feat(rust, python): pl.min & pl.max accept wildcard similar to pl.sum #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorhawell
commented
Nov 15, 2022
| ) | ||
| .alias("max") | ||
| let func = |s1, s2| { | ||
| let df = DataFrame::new_no_checks(vec![s1, s2]); |
There was a problem hiding this comment.
check if this pattern is performance-vise acceptable
2 tasks
ritchie46
reviewed
Nov 15, 2022
| // use u32 as that is not cast to float as eagerly | ||
| _ => lit(Series::new_empty("", &DataType::Int32)), | ||
| }; | ||
| fold_exprs(init, func, exprs).alias("max") |
There was a problem hiding this comment.
I think we should use reduce_expr here. That one always takes the first column and saves a redundant operation.
And it is also simpler because we don't need to come up with a init value.
| // use u32 as that is not cast to float as eagerly | ||
| _ => lit(Series::new_empty("", &DataType::Int32)), | ||
| }; | ||
| fold_exprs(init, func, exprs).alias("min") |
| res = fruits_cars.select([pl.col(pl.datatypes.Int64)]).select(pl.min(["*"])) | ||
| assert res.to_series(0).series_equal(pl.Series("min", [1, 2, 3, 2, 1])) | ||
|
|
||
| res = fruits_cars.select([pl.col(pl.datatypes.Int64)]).select(pl.max(["*"])) |
There was a problem hiding this comment.
Could we test this with pl.all() as well? That is the ideomatic way to express that you want all columns.
ritchie46
changed the title
github-actions
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pl.min and pl.max cannot handle wildcards as pl.sum.
pl.min([""]) becomes the same as pl.col(['']) because code impl handles [selected columns] as tokens before wildcard expansion.
this PR suggest to use the pl.sum impl pattern which relies on a fold that does wild card expansion with all bells and whistles.
Contra:
This PR do perform extra shallow copies which might hit performance if +1000 columns.
Maybe this can be fixed.