feat(rust,python): optimize away nested unions in lp #7861
Conversation
github-actions
bot
added
enhancement
|
|
||
| match lp { | ||
| Union { inputs, options } | ||
| if inputs |
There was a problem hiding this comment.
Can we add a state flattened_by_opt to the UnionOptions. This will prevent we run this loop every time this rule is checked. It is not uncommon to have unions over a lot of files, so it is worth it to return early in such a case.
There was a problem hiding this comment.
not sure I 100% follow. If we add a flattened_by_opt when would we set it? and when would we return early if it were set?
There was a problem hiding this comment.
We would set it in this optimization and in this optimization we return early.
These optimization rules can be called many times (until fixed point).
There was a problem hiding this comment.
@ritchie46, I added the opt state flattened_by_opt. This should be ready for final review.
universalmind303
force-pushed
the
union-optimize
branch
from
e961ec9 to
40f3fb0
Compare
|
@ritchie46 The test failures seem unrelated to my work. I already rebased from master, So i'm not entirely sure why those tests are failing. |
|
Yeap, test failure is unrelated. |
Implementation was mostly taken from the
SimplifyExprRulefor flattening nested concat_str calls.This'll flatten any arbitrarily nested unions into a single union.
closes #7855