This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Add property names to _TimeTaggedCoords #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 99.23% 99.24%
=======================================
Files 12 12
Lines 784 791 +7
=======================================
+ Hits 778 785 +7
Misses 6 6 ☔ View full report in Codecov by Sentry. |
astrojuanlu
approved these changes
May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for
_TimeTaggedCoordsclasses to specify the name of their property in the CZML. If the property name is defined it will be used in the dumped CZML, otherwise the values passed will be used.This fixes #107 and allows for bypassing similar bugs (as described in the issue) in Cesium.