Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/metadataformat #7

Merged
merged 9 commits into from
Oct 9, 2020
Merged

Feature/metadataformat #7

merged 9 commits into from
Oct 9, 2020

Conversation

xchapter7x
Copy link
Contributor

This adds a model and supporting Load function to allow for reading metadata files.

This applies to the issue here #1

@xchapter7x xchapter7x requested a review from Blokje5 October 8, 2020 09:37
@xchapter7x xchapter7x force-pushed the feature/metadataformat branch from af6d725 to 944a979 Compare October 8, 2020 10:18
Copy link
Contributor

@Blokje5 Blokje5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small naming request change, but LGTM!

pkg/metaconfig/metaconfig.go Outdated Show resolved Hide resolved
@xchapter7x
Copy link
Contributor Author

@Blokje5
Change is in... ready to merge whenever you are :)

@xchapter7x xchapter7x linked an issue Oct 9, 2020 that may be closed by this pull request
Copy link
Contributor

@Blokje5 Blokje5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Blokje5 Blokje5 merged commit 329e661 into main Oct 9, 2020
@xchapter7x xchapter7x deleted the feature/metadataformat branch October 10, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define Metadata format for Rego policies
2 participants