-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): fix bottom modal on rotation #489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bri74
approved these changes
May 14, 2024
Bri74
force-pushed
the
hotfix/bottom-modal-rotation
branch
from
May 15, 2024 07:37
3147670
to
cbd6740
Compare
github-actions
bot
added
cc-fix
PR includes fix commit
and removed
cc-fix
PR includes fix commit
labels
May 15, 2024
Bri74
force-pushed
the
hotfix/bottom-modal-rotation
branch
from
May 15, 2024 07:55
cbd6740
to
b030776
Compare
github-actions
bot
added
cc-fix
PR includes fix commit
and removed
cc-fix
PR includes fix commit
labels
May 15, 2024
Bri74
force-pushed
the
hotfix/bottom-modal-rotation
branch
from
May 15, 2024 08:19
b030776
to
6894b32
Compare
github-actions
bot
added
cc-fix
PR includes fix commit
and removed
cc-fix
PR includes fix commit
labels
May 15, 2024
FabrizioCostaMedich
pushed a commit
that referenced
this pull request
Jan 22, 2025
Bri74
added a commit
that referenced
this pull request
Jan 28, 2025
* feat(explanation-average): created modal for averaging explanation, Ref #145 * feat(course-screen): changed the averages and explanations, Ref #145 * feat(averages-info): add the test text,add description for the masterAdmissionAverageGrade, Ref #145 * fix(course-screen): fix to average error for master * fix(course-screen-modal): fix the layout of the bullet point,Ref #145 * fix(course-screen-modal): delete some not used export, and change the weight prop,Ref #145 * feat(services): webmail added (#481) * feat(webmail): add the webmail button and the hooks for the authentication,Ref #473 * fix(webmail): webmail improvements --------- Co-authored-by: FabrizioCostaMedich <[email protected]> Co-authored-by: Emanuele Coricciati <[email protected]> * fix(agenda): fix tablet agenda view (#480) * fix(agenda): fix agenda layout on tablet * fix(agenda): fix overlapping events --------- Co-authored-by: Emanuele Coricciati <[email protected]> * feat(courses): add external links in course info tab (#485) * feat(link-course): create the section external links course in CourseInfoScreen.tsx * feat(course-screen-info): add text, and change some controls when the status is loading, Ref #301 * feat(course-info): changed the layout of the links and the text , Ref #301 * fix(courses): fix translations and link indexes * chore: update api spec --------- Co-authored-by: FabrizioCostaMedich <[email protected]> Co-authored-by: Emanuele Coricciati <[email protected]> Co-authored-by: Cristina Ferrian <[email protected]> * build: bump version v.1.6.5 * ci: upgrade pipeline, unify rubies, upgrade to react-native 0.72 (#487) * ci: bump ios target sdk, enable macos github runners * ci: try to break everything * ci: try to break everything pt 2 * ci: try to unify ruby & co * ci: move caching before npm install, bump action versions * ci: upgrade ruby version * ci: more ruby fixes * ci: retry ruby fix * ci: enforce pod install * ci: react-native-permissions upgrade Podfile --------- Co-authored-by: Mobile AppleDev <[email protected]> * fix(tickets): fix ticket reply sent multiple times, Ref #479 (#491) * fix(courses): fix link indexes (#490) * fix(ui): fix bottom modal on rotation (#489) * fix(webmail): fix unread count as string (#488) * fix(places): max zoom incompatible with tiles max level (#486) * fix: upgrade mapbox version to address ios xcprivacy issue (#492) Co-authored-by: Mobile AppleDev <[email protected]> * refactor(ui): changed accept/reject grade confirm messages * fix(exams): new style exam screens (#500) * fix(exams): fix style on exams screens * fix(exams): do not show buttons when exam is not passed * fix(exams): fix checks on canBeRejected and canBeAccepted loot boxes * fix(exams): fix button position on ios and android * fix(exams): fix position of button by platform --------- Co-authored-by: Emanuele Coricciati <[email protected]> * fix(exams): provide a feedback when an exam cannot be booked, Ref #495 (#499) * fix(exams): provide a feedback when an exam cannot be booked, Ref #495 * fix(exams): fix icon not bookable and places not available, Refs #495 * fix(teaching): update file name failing when already scheduled (#496) * build: bump version * fix(exams): sort exams by date in the TeachingScreen.tsx, Ref #504 (#505) * fix(login): enable login even when fcm is not enabled, but display warning (#515) fixes: #513 * fix(exams): fix exam booked count and available count (#511) * fix(courses): make search case-insensitive (#535) * fix(courses): prioritize sorting by date, if they are the same sort by name in increasing order (#536) * fix(tickets): fix issues in ticket format, update regex for links (#533) Co-authored-by: Fabrizio Costa Medich <[email protected]> * chore: upgrade to react native 0.76 (#557) * ci: upgrade tests * fix: fix android build for updated react native version * fix: migration to mapbox 0.75.3 * build: upgrade to rn 0.76 * fix: fix types * fix: update lock files * fix: fix places types * fix: fix lock files and format * fix(places): added control to check if floorId exist and set his state * fix(places): pass current floor when press a building * fix(places): fix invalid styles on layers * fix(places): add map loader * fix(places): fix camera animation and stateful menu, remove map modal --------- Co-authored-by: QcFe <[email protected]> Co-authored-by: miky41195 <[email protected]> Co-authored-by: FabrizioCostaMedich <[email protected]> Co-authored-by: Cristina Ferrian <[email protected]> * fix(profile): handle null smartcard and relocate fcm token * fix(transcript): added explanations for grades and show only one average * feat(explanation-average): created modal for averaging explanation, Ref #145 * feat(course-screen): changed the averages and explanations, Ref #145 * feat(averages-info): add the test text,add description for the masterAdmissionAverageGrade, Ref #145 * fix(course-screen): fix to average error for master * fix(course-screen-modal): fix the layout of the bullet point,Ref #145 * fix(course-screen-modal): delete some not used export, and change the weight prop,Ref #145 * fix(profile): handle null smartcard and relocate fcm token * fix(transcript): added explanations for grades and show only one average * feat(transcript): added on-time exam scores to transcript section * fix(transcript): changed text formula average * fix(transcript): changed some text * fix(transcript): change laude text * fix(transcript): change some text * fix(transcript): change some text * fix(exams): fix typo * fix(exams): fix typo lowercase --------- Co-authored-by: Emanuele Coricciati <[email protected]> Co-authored-by: Emanuele Coricciati <[email protected]> Co-authored-by: Cristina Ferrian <[email protected]> Co-authored-by: Cristina Ferrian <[email protected]> Co-authored-by: Federico Cucinella <[email protected]> Co-authored-by: Mobile AppleDev <[email protected]> Co-authored-by: Umberto Pepato <[email protected]> Co-authored-by: Emanuele Coricciati <[email protected]> Co-authored-by: miky41195 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.