Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(login): generate clientID & persist across sessions #526

Merged
merged 4 commits into from
Jan 28, 2025
Merged

fix(login): generate clientID & persist across sessions #526

merged 4 commits into from
Jan 28, 2025

Conversation

emacoricciati
Copy link
Contributor

No description provided.

@emacoricciati emacoricciati requested a review from a team as a code owner October 4, 2024 10:24
@github-actions github-actions bot added the cc-fix PR includes fix commit label Oct 4, 2024
@github-actions github-actions bot added cc-fix PR includes fix commit and removed cc-fix PR includes fix commit labels Oct 20, 2024
@QcFe
Copy link
Member

QcFe commented Oct 20, 2024

Ciao Emanuele, thanks for your pr.

It's still not too clear to me why we need a migration for this though. Can't we take care of the generation during the login phase itself in case the ID is not already there? It also seems like a place I would expect that logic to be, instead of inside a migration...

@Bri74 Bri74 requested review from QcFe and removed request for QcFe January 23, 2025 15:28
@emacoricciati emacoricciati force-pushed the hotfix/moving-clientid-to-preferences branch from d6308c6 to f970e26 Compare January 24, 2025 14:26
@github-actions github-actions bot added cc-fix PR includes fix commit and removed cc-fix PR includes fix commit labels Jan 24, 2025
QcFe
QcFe reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@QcFe QcFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we're done let me know via teams so I can make a production apk for you to test out everything is alright

src/core/queries/authHooks.ts Outdated Show resolved Hide resolved
src/core/queries/authHooks.ts Outdated Show resolved Hide resolved
@QcFe QcFe changed the title fix(notifications): generating and moving clientId to preferences fix(login): persist clientID across sessions Jan 28, 2025
@QcFe QcFe changed the title fix(login): persist clientID across sessions fix(login): generate clientID & persist across sessions Jan 28, 2025
@github-actions github-actions bot added cc-fix PR includes fix commit and removed cc-fix PR includes fix commit labels Jan 28, 2025
@FabrizioCostaMedich FabrizioCostaMedich force-pushed the hotfix/moving-clientid-to-preferences branch from c4a2ece to 7ec2bf6 Compare January 28, 2025 12:19
@github-actions github-actions bot added cc-fix PR includes fix commit and removed cc-fix PR includes fix commit labels Jan 28, 2025
QcFe
QcFe reviewed Jan 28, 2025
View reviewed changes
src/core/queries/authHooks.ts Outdated Show resolved Hide resolved
src/core/providers/ApiProvider.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added cc-fix PR includes fix commit and removed cc-fix PR includes fix commit labels Jan 28, 2025
@QcFe QcFe force-pushed the hotfix/moving-clientid-to-preferences branch from 53b2771 to be42828 Compare January 28, 2025 16:27
@github-actions github-actions bot added cc-fix PR includes fix commit and removed cc-fix PR includes fix commit labels Jan 28, 2025
@Bri74 Bri74 merged commit 1e27895 into main Jan 28, 2025
9 checks passed
@Bri74 Bri74 deleted the hotfix/moving-clientid-to-preferences branch January 28, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QcFe QcFe QcFe approved these changes

Assignees
No one assigned
Labels
cc-fix PR includes fix commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emacoricciati @QcFe @Bri74 @FabrizioCostaMedich