Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable runtime-benchmarks feature for chain spec generator #91

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Nov 16, 2023

Based on: #78

Without this fix we cannot run benchmarks for kusama/polkadot.

Tested here: #58 (comment)

@bkontur
Copy link
Contributor Author

bkontur commented Nov 16, 2023

@bkchr I cannot push to polkadot-fellows directly, so I cannot push to your branch, but I would suggest if you could just cherry-pick this commit to your branch to avoid unnecessary begging for approves.

is it really necessary to require and follow "review" process for sub-PRs as for PRs to main branch?

@bkchr bkchr merged commit a6336ed into polkadot-fellows:bkchr-chain-spec-generator Nov 16, 2023
3 checks passed
@bkontur bkontur deleted the bkchr-chain-spec-generator branch November 16, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants