Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFTs page #7144
NFTs page #7144
Changes from 3 commits
5f74e8b
3eefab2
08526e4
2e6800d
1050ca5
3ec6d7b
12c2915
c07d59c
3757473
db7bf91
bfd5b5d
0120bc5
590d08f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now, however have has issues in the past where we blew past the ipfs.io limit - so I guess it would make sense to add something where we iterate through different IPFS gateways in the future. (As a follow-up). Something like
useIpfsLink(hash)
and then it randomly selects one from a list of known gateways and returns it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That gateway is extremely slow, if we decide to display the images on that page - it would be better to create a simple proxy/CDN service to cache them. And yes, we would need to make that gateway's URL configurable