-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ledger configs for encointer and integritee #1938
Conversation
Looks like there is a general issue around the coupling of the hw-ledger lib, with the network defaults. I am on the fence about things but now that the generic app exists, I am in the boat that these tests either: a) need to change, or b) there needs to be some rework done. It really becomes a pita for new chains that want to onboard their chains to use ledger in apps. |
pita indeed. awaiting these should make CI pass: |
@TarikGul It seems the above PR's aren't necessary according to zondax becasue we will use the generic app. May I ask you to adjust the CI tests accordingly? |
Yea, I'll work on cleaning that up today for you! |
To make things easier I wrote a replacement PR to avoid all the linter and test errors: #1939 - It is a extension of you PR :), Thanks again for your patience |
I'll make sure to release this and get this part of the release cycle next week so it can make it to the extension etc. |
Closing in favor of: #1939 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Encointer: shares derivation with Kusama as it is a teleporter systemchain
Integritee: New slip44 registered and derivation path added. Same for our Polkadot and Kusama parachains as the token is the same TEER (about to be bridged)