Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ledger configs for encointer and integritee #1938

Closed
wants to merge 3 commits into from

Conversation

brenzi
Copy link

@brenzi brenzi commented Sep 3, 2024

Encointer: shares derivation with Kusama as it is a teleporter systemchain

Integritee: New slip44 registered and derivation path added. Same for our Polkadot and Kusama parachains as the token is the same TEER (about to be bridged)

@brenzi brenzi marked this pull request as draft September 3, 2024 09:49
@brenzi brenzi marked this pull request as ready for review September 3, 2024 10:52
TarikGul
TarikGul previously approved these changes Sep 3, 2024
@TarikGul
Copy link
Member

TarikGul commented Sep 3, 2024

Looks like there is a general issue around the coupling of the hw-ledger lib, with the network defaults. I am on the fence about things but now that the generic app exists, I am in the boat that these tests either: a) need to change, or b) there needs to be some rework done. It really becomes a pita for new chains that want to onboard their chains to use ledger in apps.

@brenzi
Copy link
Author

brenzi commented Sep 3, 2024

@brenzi
Copy link
Author

brenzi commented Sep 11, 2024

@TarikGul It seems the above PR's aren't necessary according to zondax becasue we will use the generic app. May I ask you to adjust the CI tests accordingly?

Zondax/ledger-substrate-js#134 (comment)

@TarikGul
Copy link
Member

Yea, I'll work on cleaning that up today for you!

@TarikGul
Copy link
Member

To make things easier I wrote a replacement PR to avoid all the linter and test errors: #1939 - It is a extension of you PR :), Thanks again for your patience

@TarikGul
Copy link
Member

I'll make sure to release this and get this part of the release cycle next week so it can make it to the extension etc.

@TarikGul
Copy link
Member

Closing in favor of: #1939

@TarikGul TarikGul closed this Sep 11, 2024
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants