Add search plugin #310
Merged
Add search plugin #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
approved these changes
Jun 16, 2022
|
IMO a local search is way better than depending on some cloud service, so I think you did the perfect thing here :) |
|
Have not taken a look, but do agree with Shawn here on the intent. Could you just merge master to get the yarn.lock conflict sorted and I'll take a peek. |
Done |
|
@jacogr tried this locally and works well. hope you don't mind the merge |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added local search plugin, doesn't require any third party to work.
styles were updated with !important tag according to recommendation in cmfcmf/docusaurus-search-local#107 (comment)
P.S. Do we want to use full fledged Algolia DocSearch? Will require a registration https://docsearch.algolia.com/apply/
and some configuration. If not then my above solution should be good enough.