Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only rely on wasm.js (no asm.js duplication) #25

Merged
merged 4 commits into from
Jul 19, 2019
Merged

Only rely on wasm.js (no asm.js duplication) #25

merged 4 commits into from
Jul 19, 2019

Conversation

jacogr
Copy link
Member

@jacogr jacogr commented Jul 19, 2019 •
edited
Loading

Stub asm.js by default, however provide and override via package.json for the react-native environment. Part of #19

  • This means no actual env variables
  • react native gets a polyfill (syntax looks sound, but untested)
  • other environments don't try to pack asm.js (which is a massive regression and slowdown)
  • mock the stub to the real asm.js for the CI asm.js tests

@jacogr jacogr merged commit 8c6d2ae into master Jul 19, 2019
@jacogr jacogr deleted the jg-rm-asm branch July 19, 2019 09:06
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacogr @polkadot-js-bot