Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/zh/refactor shim #142

Merged
merged 15 commits into from
Aug 13, 2019
Merged

Conversation

mzxyz
Copy link
Contributor

@mzxyz mzxyz commented Jul 20, 2019

  1. Solved part of the issue 111 : enable sr25519.

  2. Refactor shim: using babel-rewrite to replace rn-nodeify

  3. Fix Issue 141

Have test on real device, mnemonicGenerate works as expect, but there has some UI interaction issues at create account page, should open another issue for that.

@0xthreebody
Copy link
Collaborator

Hey, @huanday Thanks for your pioneering efforts. If you need any help, let me know here.

@mzxyz
Copy link
Contributor Author

mzxyz commented Jul 21, 2019

@jiangfuyao I forgot to set a reviewer for this PR, could you help review and merge this?

@0xthreebody
Copy link
Collaborator

@huanday Yeap, thansk, I will to reviewer it.

@0xthreebody 0xthreebody added the pleasereview Pull request needs review. label Jul 26, 2019
@0xthreebody 0xthreebody self-requested a review July 26, 2019 12:24
@0xthreebody
Copy link
Collaborator

@huanday got error:
屏幕快照 2019-07-27 上午2 20 14

@mzxyz
Copy link
Contributor Author

mzxyz commented Jul 26, 2019

@jiangfuyao I didn't got the above error. I do some updates on the codebase. Could you checkout the latest code and delete node_modules and run yarn install again.

I also test yarn run bundle-ios all things should work properly now, thanks

Copy link
Collaborator

@0xthreebody 0xthreebody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is working now, Nice. Have two questions:

  • Did you have the issue: running the app, the custom keyboard will don't work, auto exit.
  • What's the way to support Sr25519 on UI, what's need to fix?

@mzxyz
Copy link
Contributor Author

mzxyz commented Jul 27, 2019

@jiangfuyao

  • For the first question, just look into previous commit, the issue was introduced by this commit, fixed here

  • If you mean Create account can choose Sr25519 or ed25519, just add another inputPicker to enable user to choose which one to generate keyPair. For codebase init keyring like new Keyring({ type: 'sr25519 | ed25519' })

@0xthreebody
Copy link
Collaborator

@huanday This fixed CustomKeyboard auto exit. I tested in Android before, so iOS have issue. The iOS lose Auto focus function, and other pages(staking/transfer/voting) can't to show the system keyboard, which not is password input.

@mzxyz
Copy link
Contributor Author

mzxyz commented Jul 27, 2019

@jiangfuyao Can open another issue to address CustomKeyboard problem.

Update using sr25519 to generate keys. Need to run yarn install to update the modules after checkout the codebase.

Also using native api to generate random numbers in this commit, it may solve issue 120

Copy link
Collaborator

@0xthreebody 0xthreebody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huanday Last time I tested is ok, but now, got error:

transform[stdout]: <--- Last few GCs ---> with --max_old_space_size=4096.

@mzxyz
Copy link
Contributor Author

mzxyz commented Aug 4, 2019

@jiangfuyao Could you try to run yarn start manually then just open you app and reload the bundle. There has an issue with the default configuration for metro bundler which doesn't have env param --max_old_space_size=4096

@mzxyz
Copy link
Contributor Author

mzxyz commented Aug 4, 2019

I have config bundle generation before, like this:

Screen Shot 2019-08-05 at 11 06 25 AM

But for my research, it only processed when runing react-native bundle or generate released build.

We can fix it by hacking the code inside react-native-xcode.sh, changing [ -z "$NODE_ARGS" ] && export NODE_ARGS="" to [ -z "$NODE_ARGS" ] && export NODE_ARGS="--max_old_space_size=4096"

@0xthreebody 0xthreebody merged commit 44dbbf4 into polkawallet-io:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pleasereview Pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building issue: Tried to register two views with the same name RNSVGPath
2 participants