-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/zh/refactor shim #142
Feat/zh/refactor shim #142
Conversation
Hey, @huanday Thanks for your pioneering efforts. If you need any help, let me know here. |
@jiangfuyao I forgot to set a reviewer for this PR, could you help review and merge this? |
@huanday Yeap, thansk, I will to reviewer it. |
@huanday got error: |
@jiangfuyao I didn't got the above error. I do some updates on the codebase. Could you checkout the latest code and delete I also test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is working now, Nice. Have two questions:
- Did you have the issue: running the app, the custom keyboard will don't work, auto exit.
- What's the way to support
Sr25519
on UI, what's need to fix?
@jiangfuyao
|
@huanday This fixed CustomKeyboard auto exit. I tested in Android before, so iOS have issue. The iOS lose Auto focus function, and other pages(staking/transfer/voting) can't to show the system keyboard, which not is password input. |
@jiangfuyao Can open another issue to address CustomKeyboard problem. Update using Also using native api to generate random numbers in this commit, it may solve issue 120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huanday Last time I tested is ok, but now, got error:
transform[stdout]: <--- Last few GCs --->
with --max_old_space_size=4096
.
@jiangfuyao Could you try to run |
I have config bundle generation before, like this: But for my research, it only processed when runing We can fix it by hacking the code inside |
Solved part of the issue 111 : enable sr25519.
Refactor shim: using
babel-rewrite
to replacern-nodeify
Fix Issue 141
Have test on real device,
mnemonicGenerate
works as expect, but there has some UI interaction issues atcreate account
page, should open another issue for that.