-
-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ipc module action #2528
Ipc module action #2528
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2528 +/- ##
==========================================
- Coverage 10.47% 10.42% -0.06%
==========================================
Files 147 147
Lines 10166 10220 +54
==========================================
Hits 1065 1065
- Misses 9101 9155 +54
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The main thing is that we should make the hook
action take 0-based indices. I want to move away from 1-based indices in general, especially when it references lists that are 0-based
Co-authored-by: Patrick Ziegler <[email protected]>
We shouldn't introduce any breaking changes here.
|
Thanks :) |
What type of PR is this? (check all applicable)
Description
This PR adds
hook
,prev
,next
andreset
actions to the ipc moduleRelated Issues & Documents
Closes #2464
Documentation (check all applicable)
Edit: add wiki documentation needs