Universal Query Routing #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new generic Features for Monitoring (Ui and Types). - Implement MapDb Monitoring Backend.
- use Transaction for holding MonitoringJob
- add subscriber model to MonitoringService
- remove subscriber concept - queue events
vogti
reviewed
Nov 30, 2021
| approximatedCosts, | ||
| preCosts, | ||
| postCosts, | ||
| icarusCosts, |
There was a problem hiding this comment.
What is the difference between postCosts and icarusCosts?
There was a problem hiding this comment.
The naming in the class is a little bit a mess, I guess the term icarus should be removed completely.
But in general, postCosts are probabilities and icarusCosts are absolute measured times.
vogti
reviewed
Nov 30, 2021
monitoring/src/main/java/org/polypheny/db/monitoring/events/metrics/DmlDataPoint.java
Outdated
Show resolved
Hide resolved
vogti
reviewed
Dec 1, 2021
dbms/src/main/java/org/polypheny/db/routing/routers/AbstractDqlRouter.java
Show resolved
Hide resolved
vogti
approved these changes
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new Universal Query Routing in Polypheny-DB.
Universal Query Routing enables multiple possible routers. For a given query, multiple Query Plans will be proposed (and cached).
There have been major changes in the routing classes (especially AbstractRouter).
There is a new BaseRouter class, providing base methods used for routing.
Further, DML queries and DQL queries are handled separately (new DmlRouter interface).
Finally, there was a major concept change in the AbstractQueryProcessor.