Allow self signed certificates for kroki

[jdputschadi]

When kroki is self-hosted, a self-signed certificate may be in the SSL certificate chain. This update allows a flag to be set to allow the self-signed certificate.

[pomdtr]

Hey, thanks for the PR. Did you investigate other ways to enable this without disabling ssl altogether. You can point node to a custom certificate using the NODE_EXTRA_CA_CERTS env var

[jdputschadi]

I did not do that investigation. It strikes me that this patch does not disable ssl altogether, it disables in when the following, plugin-specific, settings are set: "markdown-kroki.url": "https://kroki.web.analog.com", "markdown-kroki.allowSelfSignedHost": true, In this case, I am pointing the plugin to a host my company controls, and has a CA certificate that is self-signed. The patch disables SSL certificate checks for the host specified in “markdown-kroki.url” and only that host. It also disables the check only for this plugin. In our environment, I can share .vscode/settings.json on a per-project basis (i.e. workspace-specific setting), while I cannot distribute the CA certs and get people to change their environments that launch VSCODE to reliably point to the extra certs. It strikes me the approach I’m suggesting allows users and teams to choose to override the SSL certificate checks in a way that meets their needs without unduly compromising security. Jeff. On Oct 7, 2024, at 10:44 AM, Achille Lacoin ***@***.***> wrote: [External] Hey, thanks for the PR. Did you investigate other ways to enable this without disabling ssl altogether. You can point node to a custom certificate using the NODE_EXTRA_CA_CERTS env var — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/pomdtr/vscode-markdown-kroki/pull/15*issuecomment-2397529102__;Iw!!A3Ni8CS0y2Y!9GQ6EP-YZcSZyq6kIqpQMK9M9m1H8awft4-RVKV4UvCkO2m390l56duU2PvTh8BJYBaS1RJCn5DnTiGm8FgF4bqbTcM$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BD7YHQBR6TH7FISKPTJ3L5DZ2LCBNAVCNFSM6AAAAABPQOEHKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJXGUZDSMJQGI__;!!A3Ni8CS0y2Y!9GQ6EP-YZcSZyq6kIqpQMK9M9m1H8awft4-RVKV4UvCkO2m390l56duU2PvTh8BJYBaS1RJCn5DnTiGm8FgFqck-4Wc$>. You are receiving this because you authored the thread.Message ID: ***@***.***>