Improve the logging of errors and use JSON #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devin Petersohn <[email protected]>
mvashishtha
reviewed
May 1, 2023
| @@ -105,8 +105,8 @@ def decorator(obj: Any) -> Any: | |||
|
|
|||
| assert isinstance(modin_layer, str), "modin_layer is somehow not a string!" | |||
|
|
|||
| start_line = f"START::{modin_layer.upper()}::{name or obj.__name__}" | |||
| stop_line = f"STOP::{modin_layer.upper()}::{name or obj.__name__}" | |||
| start_line = f"STAGE: START, METHOD: {name or obj.__name__}" | |||
There was a problem hiding this comment.
Why drop the layer for pushdown? I thought it was useful, especially to distinguish methods in different layers that have the same name, e.g. query compiler apply vs dataframe apply vs base apply.
Also, is it ok to drop the modin_layer in open source?
jkew
reviewed
May 1, 2023
| @@ -105,8 +105,8 @@ def decorator(obj: Any) -> Any: | |||
|
|
|||
| assert isinstance(modin_layer, str), "modin_layer is somehow not a string!" | |||
|
|
|||
| start_line = f"START::{modin_layer.upper()}::{name or obj.__name__}" | |||
| stop_line = f"STOP::{modin_layer.upper()}::{name or obj.__name__}" | |||
| start_line = f"STAGE: START, METHOD: {name or obj.__name__}" | |||
There was a problem hiding this comment.
This is good for now but I would if we collapse START/STOP we should try to include duration.
jkew
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date