Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging around multiple push attempts #35

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

SeanTAllen
Copy link
Member

If a failure was encountered, we wouldn't get push logging for
each push only the first.

@SeanTAllen SeanTAllen requested a review from a team September 11, 2020 17:37
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Sep 11, 2020
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 35.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

If a failure was encountered, we wouldn't get push logging for
each push only the first.
@SeanTAllen SeanTAllen force-pushed the improve-pull-messaging branch from 69a32f9 to ed0ad18 Compare September 11, 2020 17:46
@SeanTAllen SeanTAllen merged commit 3053ece into master Sep 11, 2020
@SeanTAllen SeanTAllen deleted the improve-pull-messaging branch September 11, 2020 17:53
github-actions bot pushed a commit that referenced this pull request Sep 11, 2020
github-actions bot pushed a commit that referenced this pull request Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants