Skip to content

Commit

Permalink
Remove logger package from the standard library (#4035)
Browse files Browse the repository at this point in the history
Closes #4030
  • Loading branch information
SeanTAllen authored Feb 23, 2022
1 parent bdea439 commit b52db3e
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 342 deletions.
15 changes: 15 additions & 0 deletions .release-notes/remove-logger.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
## Remove `logger` package from the standard library

The `logger` package is intentionally limited in its functionality and leans heavily into reducing messaging overhead between actors to the point of intentionally sacrificing functionality.

Our stated belief as a core team has been that the standard library isn't "batteries included". We have also stated that libraries were we believe it would be "relatively easy" for multiple competing standards to appear in the community shouldn't be included in the standard library unless other factors make inclusion important.

Some other factor we have discussed in the past include:

- Not having a standard library version would make interop between different 3rd-party Pony libraries difficult.
- The functionality is required or called for by an interface in one or more standard library classes.
- We consider the having the functionality provided to be core to the "getting started with Pony experience".

We don't believe that any of above 3 points apply to the `logger` package. Therefore, we've removed `logger` from the standard library and turned it into it's own [stand alone library](https://github.com/ponylang/logger).

If you were using the `logger` package, visit it's new home and follow the "How to Use" directions.
168 changes: 0 additions & 168 deletions packages/logger/_test.pony

This file was deleted.

172 changes: 0 additions & 172 deletions packages/logger/logger.pony

This file was deleted.

2 changes: 0 additions & 2 deletions packages/stdlib/_test.pony
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ use format = "format"
use ini = "ini"
use itertools = "itertools"
use json = "json"
use logger = "logger"
use math = "math"
use net = "net"
use ponybench = "ponybench"
Expand Down Expand Up @@ -62,7 +61,6 @@ actor \nodoc\ Main is TestList
ini.Main.make().tests(test)
itertools.Main.make().tests(test)
json.Main.make().tests(test)
logger.Main.make().tests(test)
math.Main.make().tests(test)
net.Main.make().tests(test)
process.Main.make().tests(test)
Expand Down

0 comments on commit b52db3e

Please sign in to comment.