Skip to content

Commit

Permalink
Don't emit internal methods to library headers (#1890)
Browse files Browse the repository at this point in the history
Closes #1881.
  • Loading branch information
Benoit Vey authored and jemc committed May 5, 2017
1 parent 54fbf3c commit d81ce0d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ All notable changes to the Pony compiler and standard library will be documented
- Compiler error instead of crash for invalid this-dot reference in a trait. ([PR #1879](https://github.com/ponylang/ponyc/pull/1879))
- Compiler error instead of crash for too few args to constructor in case pattern. ([PR #1880](https://github.com/ponylang/ponyc/pull/1880))
- Pony runtime hashmap bug that resulted in issues [#1483](https://github.com/ponylang/ponyc/issues/1483), [#1781](https://github.com/ponylang/ponyc/issues/1781), and [#1872](https://github.com/ponylang/ponyc/issues/1872). ([PR #1886](https://github.com/ponylang/ponyc/pull/1886))
- Compiler crash when compiling to a library (issue #1881)


### Added

Expand Down
8 changes: 6 additions & 2 deletions src/libponyc/codegen/genheader.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,12 @@ static void print_params(compile_t* c, printbuf_t* buf, ast_t* params)

static bool emit_fun(ast_t* fun)
{
// No signature for any function with a tuple argument or return value, or
// any function that might raise an error.
// No signature for any internal function (i.e. functions without an AST), or
// any function with a tuple argument or return value, or any function that
// might raise an error.
if(fun == NULL)
return false;

AST_GET_CHILDREN(fun, cap, id, typeparams, params, result, can_error);

if(ast_id(can_error) == TK_QUESTION)
Expand Down

1 comment on commit d81ce0d

@SeanTAllen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding CHANGELOG entries by hand. Let's make sure to add a link to the PR and if it has a link to issue, to that as well. It makes the release notes much better. I'm going to push a manual fix to that.

Please sign in to comment.