Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release 0.11.4 #1738

Closed
killerswan opened this issue Mar 22, 2017 · 57 comments
Closed

release 0.11.4 #1738

killerswan opened this issue Mar 22, 2017 · 57 comments
Assignees
@killerswan

Comments

@killerswan
Copy link
Member

There's a wee bit of stuff in here now that I'd like to confirm also works right on a release branch: release...master

Anything pending that we should wait up for? @sylvanc @jemc
@SeanTAllen
Copy link
Member

DO IT!

@killerswan killerswan mentioned this issue Mar 23, 2017
Merged
@killerswan
Copy link
Member Author

I've been distracted by https://github.com/killerswan/homebrew-pony (for # 1732) this afternoon, but will do this tomorrow, when more people are around.

@SeanTAllen
Copy link
Member

@killerswan do you have this or should I do it? i'd rather you did it because if something does go sideways you are in best position to address.

@SeanTAllen SeanTAllen mentioned this issue Mar 23, 2017
Merged
@killerswan
Copy link
Member Author

I'll give it a shot now. 😅

@killerswan
Copy link
Member Author

killerswan commented Mar 23, 2017 •
edited
Loading

Haha, our clever usage of [skip ci] is uncool here. Because what I have to say is that our potentially golden commit, 44ef576 (master), is actually a couple changes since the last master build that was green on Travis (delta from CI: b99d5b6...44ef576, delta from last release to master: 917610c...44ef576).

And it doesn't look like that commit got deployed from AppVeyor to Bintray, see here:
* https://ci.appveyor.com/project/ponylang/ponyc/build/ponyc-0.11.3-2704.b99d5b6
* https://dl.bintray.com/pony-language/ponyc-win/ (2704 is missing!)

Not ready to release until I understand that, hmm.

@killerswan
Copy link
Member Author

Wait that's fine. Master doesn't deploy anymore, wake up Kevin. But look it was passing tests both on AppVeyor and Travis:

@SeanTAllen
Copy link
Member

Why do you say it won't deploy anymore?

@SeanTAllen
Copy link
Member

o because 44ef576

should have triggered a travis build (but not an appveyor one), correct?

@SeanTAllen
Copy link
Member

SeanTAllen commented Mar 23, 2017 •
edited
Loading

O no, that had skip ci in it. I'm not sure why you say master won't deploy. What do you mean?

Everything looks fine from here.

@killerswan
Copy link
Member Author

I was looking at Bintray and saying "WHERE ARE MY BINARIES!? 😿 " Only release builds go to Bintray.

@killerswan
Copy link
Member Author

👍

So now with 44ef576 dubbed "golden", I'm running the release script (after creating an "origin" remote, haha)...

@SeanTAllen
Copy link
Member

ah yes, was the release doc not updated to reflect that we don't do master binaries? i thought i updated that.

@killerswan
Copy link
Member Author

Just my brain needed a couple cycles there.

@killerswan
Copy link
Member Author

killerswan commented Mar 23, 2017 •
edited
Loading

OK, after a bit of tweaking of my local repo (origin, and tracking setup) to make git pull work, viola...

And I've added the new release here:

But this change on master is not what I expected: 44ef576...master. @SeanTAllen what gives?

@killerswan
Copy link
Member Author

CI:

@SeanTAllen
Copy link
Member

SeanTAllen commented Mar 23, 2017 •
edited
Loading

@killerswan i've never seen it to do that to the CHANGELOG before. Can you roll it back and fix up by hand?

Sorry, not rollback nec. just fix up the oops, why did you blow all that stuff away-ness.

@SeanTAllen
Copy link
Member

@Theodus the release script did weird things to the changelog. I assume its related to your last change. Can you take a look?

@SeanTAllen
Copy link
Member

@killerswan travis release failed on building documentation to push to standard lib update.

@killerswan
Copy link
Member Author

It's hard to build the docs when the Pony build failed. Not sure why this didn't stop the build here:

Building ponyc packages for deployment...
threads.c
gcc -MMD -MP -march=x86-64 -mtune=intel -Werror -Wconversion -Wno-sign-conversion -Wextra -Wall -mcx16 -O3 -DNDEBUG -std=gnu11 -fexceptions -DPONY_VERSION=\"0.11.4-e91d517\" -DLLVM_VERSION=\"3.9.1\" -DPONY_COMPILER=\"gcc\" -DPONY_ARCH=\"x86-64\" -DBUILD_COMPILER=\""gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4"\" -DPONY_BUILD_CONFIG=\"release\" -D_FILE_OFFSET_BITS=64  -DPONY_NO_ASSERT -c -o build/release/obj/libponyrt/platform/threads.o src/libponyrt/platform/threads.c  -I src/common/ -I src/libponyrt/
src/libponyrt/platform/threads.c:1:0: error: bad value (intel) for -mtune= switch
 #ifdef __linux__
 ^
make: *** [build/release/obj/libponyrt/platform/threads.o] Error 1

@SeanTAllen
Copy link
Member

So, that problem is the version of gcc is old. I believe we recently fixed that.

@SeanTAllen
Copy link
Member

yeah, that was supposed to be fixed by: 82ac4a3

did that get undone somehow?

@SeanTAllen
Copy link
Member

also WEEEEEEEE! computers

😅

@killerswan
Copy link
Member Author

  1. My new pull req. to revert the changelog badness: Revert the odd robotic garbling of our changelog ("Prep for 0.11.4 release") #1742
  2. Looking into GCC now...

@killerswan killerswan changed the title release 0.11.4 release 0.11.4 and 0.11.5 Mar 23, 2017
@SeanTAllen
Copy link
Member

I thought you were in this repo rather than your own when you did everything. The release script and instructions assume you are working in a clone of the ponyc repo. We should update the release instructions to make that clear. You have access to do from a clone of this repo, yes @killerswan ?

@killerswan
Copy link
Member Author

These are the remotes I have set up:

ponyc $ git remote -v
kevin	[email protected]:killerswan/ponyc.git (fetch)
kevin	[email protected]:killerswan/ponyc.git (push)
origin	[email protected]:ponylang/ponyc.git (push)
origin	[email protected]:ponylang/ponyc.git (fetch)
theodus	https://github.com/Theodus/ponyc.git (fetch)
theodus	https://github.com/Theodus/ponyc.git (push)
upstream	[email protected]:ponylang/ponyc.git (fetch)
upstream	[email protected]:ponylang/ponyc.git (push)

That was why my comment about tracking: git pull is not a command I ever type myself.

@SeanTAllen
Copy link
Member

@killerswan write, the release instructions assume you aren't using a fork, but are using upstream: a clone of ponylang/ponyc.

@killerswan
Copy link
Member Author

Forks and clones are the same thing.

@SeanTAllen
Copy link
Member

@killerswan i dont think it caused any problems either, i just think someone less experienced than you could have gotten tripped up so i wanted to note that i'd seen and addressed in docs.

@SeanTAllen
Copy link
Member

we wanted to update to tune=intel on release. that should give the better performance for release builds than what we currently have.

@killerswan
Copy link
Member Author

That's also what we have in our Dockerfile. Are those breaking?

@SeanTAllen
Copy link
Member

ugh. it appears we never verified this worked on travis.

@SeanTAllen
Copy link
Member

i'm about to disappear on you for a couple hours. i'd say, we turn off the tune for now, remove the change log entry for it from release notes and address later.

@killerswan
Copy link
Member Author

((nod))

@SeanTAllen
Copy link
Member

also what's the emoji for BLARG

This was referenced Mar 24, 2017
Merged
Merged
@killerswan
Copy link
Member Author

My removal of 'tune=intel' is going on master now from #1743.

@killerswan
Copy link
Member Author

To amend this 0.11.4 release:

  • master's now here: eaf9a86,
  • this shows recent changes we've made: b99d5b6...eaf9a86
  • this will be the commits between 0.11.3 and 0.11.4: 917610c...eaf9a86 (plus a merge commit and me moving the 0.11.4 tag).

@killerswan
Copy link
Member Author

killerswan commented Mar 24, 2017 •
edited
Loading

OK, so release is now 0.11.4 at 5618e86, and master's at 8fc1403.

Builds happening here:

@killerswan
Copy link
Member Author

Issues so far:

  1. release.sh garbles the changelog (see here),
  2. (resolved temporarily) Travis build didn't work with tune=intel,
  3. Travis build has a Travis->Bintray deployment regex problem resulting in a message: [Bintray Upload] Warning: Path: \/home\/travis\/build\/ponylang\/ponyc\/build\/bin\/ does not exist. which causes nothing to be deployed (just like I've fixed elsewhere, but which I don't understand how it could be introduced when the pattern in bintray.[ba]sh hasn't changed), and
  4. AppVeyor build hasn't started here (yet).

@killerswan
Copy link
Member Author

@kulibali do you have any idea why AppVeyor wouldn't run even after I've pushed a few new commits to the release branch (and moved the 0.11.4 tag to its latest)?

@killerswan
Copy link
Member Author

I have a fix for the includePattern (path "does not exist") error in progress here: #1744.

@SeanTAllen
Copy link
Member

@killerswan are the commits all for things in the appveyor skip list?

@killerswan
Copy link
Member Author

Ahahaa, possibly!

@SeanTAllen
Copy link
Member

@killerswan the previous 0.11.4 should be fine for windows.

@killerswan
Copy link
Member Author

OK, so that leaves the release.sh issue.

The changes here between 0.11.3 and now didn't introduce the problem: 917610c...eaf9a86#diff-e55bb7573f1110c8b2a6922fe8cccf48

Have I failed to set some envvar to avoid using macOS's sed? 👻

@killerswan
Copy link
Member Author

killerswan commented Mar 24, 2017 •
edited
Loading

I've filed a new ticket for that, #1745, since someone other than me might be able to fix it faster.

@killerswan
Copy link
Member Author

killerswan commented Mar 24, 2017 •
edited
Loading

OK, to really recap, before I go eat food:

  • the latest Windows release build is now 7c3d44f (ci, win),
  • the latest Linux and docs release builds are now bac04bb (ci, rpm, deb, src), and
  • the 0.11.4 tag now points at b53fcb8 which includes a cleaned up changelog and all the merge commits (full delta).

Work to fix release.sh should be tested on another repository, and proceed on master, now.

I'm now wrapping up:

  • release tagged and stable
  • Travis builds green and deployed to Bintray
  • AppVeyor builds green and deployed to Bintray
  • commenting on open pull reqs.
  • updating the GitHub release
  • doing a Homebrew pull req.
  • confirming Homebrew pull req. merged
  • notifying Gentoo and SUSE people that a release is happenin'
  • informing #ponylang
  • informing pony-user

@killerswan
Copy link
Member Author

@stefantalpalaru, FYI, we're deploying the 0.11.4 release now!

@killerswan killerswan changed the title release 0.11.4 and 0.11.5 release 0.11.4 Mar 24, 2017
@killerswan killerswan mentioned this issue Mar 24, 2017
Closed
@killerswan
Copy link
Member Author

killerswan commented Mar 24, 2017 •
edited
Loading

@SeanTAllen I've made a post here: https://pony.groups.io/g/user/message/940

Feeling I've not used enough emojis yet, but there you go.

@killerswan
Copy link
Member Author

shetland-ponies
(cuties from here)

@killerswan killerswan self-assigned this Mar 24, 2017
@stefantalpalaru
Copy link
Contributor

Gentoo ebuild updated.

@killerswan
Copy link
Member Author

Thanks, @stefantalpalaru! 🐴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@killerswan killerswan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SeanTAllen @killerswan @stefantalpalaru