Rename the bintray descriptor script, ShellCheck it, and note it makes JSON not YAML [skip ci] #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty good but that commit first line is wicked long and going to be a pain when using most tooling. Can you shorten down and add more detail in the body? |
killerswan
force-pushed
the
json-not-yaml
branch
from
f018e60 to
99be6ad
Compare
This commit * renames the script to .BASH, * tweaks a couple things for ShellCheck, and * uses a .JSON instead of .YML extension on the descriptor file which the script generates (because it isn't YAML). Also: [skip ci], since this code runs on releases.
killerswan
force-pushed
the
json-not-yaml
branch
from
99be6ad to
0771065
Compare
|
/me shakes fist at Linus Torvalds' paper-printed TTY design constraints |
|
Thank you sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this won't run on a master build, just release.
Conveniently: #1738 is coming...
@SeanTAllen Have I fat-fingered anything here?