Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default arguments show as "= seq" in generated stdlib docs #3015

Closed
doesntgolf opened this issue Feb 21, 2019 · 3 comments
Closed

Default arguments show as "= seq" in generated stdlib docs #3015

doesntgolf opened this issue Feb 21, 2019 · 3 comments
Assignees
@SeanTAllen

Comments

@doesntgolf
Copy link

In the stdlib documentation, function/behavior/constructor signatures where any parameter has a default value show up as = seq. Here are two example pages:

https://stdlib.ponylang.io/regex-Regex/
https://stdlib.ponylang.io/term-Readline/
@SeanTAllen
Copy link
Member

SeanTAllen commented Feb 21, 2019 •
edited
Loading

docgen.c line 651 and line 693 is where this is handled.

@SeanTAllen
Copy link
Member

This broke with 394c94e, PR #2242

@SeanTAllen SeanTAllen self-assigned this Feb 21, 2019
SeanTAllen added a commit that referenced this issue Feb 21, 2019
@SeanTAllen
Fix default arguments not being displayed correctly in generated docs
bb89361 
This was broken when the shape of the ast was change in PR #2242

Closes #3015
This was referenced Feb 21, 2019
Merged
Merged
jemc pushed a commit that referenced this issue Feb 26, 2019
@SeanTAllen @jemc
Fix default arguments not being displayed correctly in generated docs (…
71958c7 
…#3018)

This was broken when the shape of the ast was change in PR #2242

Closes #3015
@SeanTAllen
Copy link
Member

@doesntgolf this will be fixed with the release of 0.27.0 this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeanTAllen SeanTAllen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SeanTAllen @doesntgolf