Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests being excluded or skipped unnecessarily. #1778

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Fix tests being excluded or skipped unnecessarily. #1778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/ponytest/pony_test.pony
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,19 +242,20 @@ actor PonyTest
"""
Run the given test, subject to our filters and options.
"""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you kill this? we generally start the first line of the method abutting the doc string.

if _do_nothing then
return
end

var name = test.name()

// Ignore any tests that satisfy our "exclude" filter
if name.at(_exclude, 0) then
if (_exclude != "") and name.at(_exclude, 0) then
return
end

// Ignore any tests that don't satisfy our "only" filter
if not name.at(_only, 0) then
if (_only != "") and (not name.at(_only, 0)) then
return
end

Expand Down