Improve Visual Studio and Microsoft C++ Build Tools detection. #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `ponyc` would only look for a linker from the version of Visual Studio with which it was compiled, and only looked at one registry key for install information. A recent change (44b2d56) broke support for Visual Build Tools C++ 2015. This change provides registry key and path configuration information for several configurations, regardless of how `ponyc` was compiled for Windows: - Visual Studio 2017 full install - Visual C++ Build Tools 2017 - Visual Studio 2015 full install - Visual C++ Build Tools 2015 The change also removes support for Windows SDKs prior to version 10, as `README.md` now specifies version 10.
chalcolith
added
changelog - fixed
|
Just got a user in IRC who ran into the VS2015 detection issue, so this should probably trigger another patch release (0.12.3). Should we add VS 2017 to the README before merging this? |
|
Agreed on release |
SeanTAllen
added
the
triggers release
Closed
ponylang-main
added a commit
that referenced
this pull request
Apr 1, 2017
|
Thanks @kulibali! |
|
Thank you both! |
|
I am using ponyc-0.12.3 under windows 7 64bit with Why should I install gross And |
|
The Windows 10 SDK is required to use Pony on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
ponycwould only look for a linker from the version of Visual Studio with which it was compiled, and only looked at one registry key for install information. A recent change (44b2d56) broke support for Visual Build Tools C++ 2015.This change provides registry key and path configuration information for several configurations, regardless of how
ponycwas compiled for Windows:The change also removes support for Windows SDKs prior to version 10, as
README.mdnow specifies version 10.