Don't call TCPConnection backpressure notifies incorrectly #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible under rare circumstances to call `throttled` and `unthrottled` on a `TCPConnectionNotify` at the incorrect time. This happens because we were not explicitly tracking whether our connection was throttled or not. If you were to be running without one shot enabled (unlikely now), this code would spuriously call `unthrottled`. With this change, we no longer have to worry that some other change might inadvertently start calling `throttled` or `unthrottled` incorrectly.
SeanTAllen
added
the
changelog - fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible under rare circumstances to call
throttledandunthrottledon aTCPConnectionNotifyat the incorrect time. Thishappens because we were not explicitly tracking whether our connection
was throttled or not.
If you were to be running without one shot enabled (unlikely now), this
code would spuriously call
unthrottled. With this change, we no longerhave to worry that some other change might inadvertently start calling
throttledorunthrottledincorrectly.