Fix implicit fallthrough in array inference. #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these returns, these switches fail to compile with gcc 7.2.0 because of -Werror=implicit-fallthrough.
SeanTAllen
added
the
changelog - fixed
|
Awesome catch. Thanks @tokenrove! |
jemc
changed the title
|
Excellent! Thanks for fixing this bug. |
ponylang-main
added a commit
that referenced
this pull request
Sep 27, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these returns, these switches fail to compile on a Debian system with gcc 7.2.0 because of
-Werror=implicit-fallthrough. I didn't spend any time scrutinizing this part of the code to determine if the fallthroughs were intentional, and it's possible that there's something strange about my setup that causes this to be a problem, but I figured the best course of action was just to open a PR and see what happens.I don't think it makes a difference, but the command I used to build was: