Don't suspend schedulers if terminating and reset steal_attempts on wake #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, a scheduler thread could potentially suspend even if it was supposed to be terminating. This commit makes it so that it only goes down the suspend path if the thread is not terminating. Additionally, we now set `steal_attempts = 0` on waking from a suspend to ensure that the scheduler thread will try to steal from all other threads prior to suspending again.
|
@winksaville can you test this to see if you still end up with the #2445. If you don't, I'll do a 0.21.2 release to get this out. |
|
Thanks @dipinhora |
SeanTAllen
approved these changes
Dec 24, 2017
|
I'll give it a try tonight or tomorro bew, txs.
…On Sun, Dec 24, 2017, 11:54 AM Sean T Allen ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2447 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA-hHHOovhq5KEjRi8KNgSnUVKokar4oks5tDqv8gaJpZM4RL_fi>
.
|
winksaville
added a commit
to winksaville/ponyc
that referenced
this pull request
Dec 25, 2017
…:ponylang/ponyc into support-openssl1.1-simple-travis Test PR "Don't suspend schedulers if terminating and reset steal_attempts on wake" ponylang#2447
|
I'm now running a test that includes this change, the prior run hung after 40minutes. My test, which runs stdlib --sequential in a loop forever and has typically failed in less than an hour. We'll see what happens. |
|
After 4 plus hours still no hang, I declare it "fixed" and we should take this change. |
Closed
|
Thanks for testing @winksaville |
SeanTAllen
added a commit
that referenced
this pull request
Dec 25, 2017
Forgot to add before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, a scheduler thread could potentially suspend even
if it was supposed to be terminating. This commit makes it so that it
only goes down the suspend path if the thread is not terminating.
Additionally, we now set
steal_attempts = 0on waking from a suspendto ensure that the scheduler thread will try to steal from all other
threads prior to suspending again.
@winksaville In theory, this might fix #2445 if somehow a scheduler thread was being suspended again after being woken when it should have terminated instead.