Add U64 type to cli package.
#2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
added
the
changelog - added
jemc
changed the title
cli package.
ponylang-main
added a commit
that referenced
this pull request
Jan 17, 2018
|
Because the up a few lines the example parameter was 42.
…On Wed, Jan 17, 2018 at 12:52 PM Sean T Allen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/cli/command_spec.pony
<#2488 (comment)>:
> @@ -207,13 +207,29 @@ class val OptionSpec
Creates an Option with an I64 typed value that can be used like
`--count=42 -C=42`
to yield an option value like
- `cmd.option("count").i64() == I64(64)`.
+ `cmd.option("count").i64() == I64(42)`.
any reason for this change?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2488 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA-hHEYSldG5a94Qib3FU2NyBKK_E3Jlks5tLl1zgaJpZM4Rc5Ho>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.