Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler crash related to array inference. #2603

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Conversation

mfelsche
Copy link
Contributor

that can possibly return null.

fixes #2602

would you want a test for that?

that can possibly return null.

fixes #2602
@jemc
Copy link
Member

jemc commented Mar 21, 2018

Yeah, can we add @dangoldin's test case as a regression test?

to ensure pony properly reports the error and does not assert
@mfelsche mfelsche added changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge and removed bug: 4 - in progress labels Mar 28, 2018
@jemc jemc changed the title add NULL check to array inference code Fix compiler crash related to array inference. Mar 28, 2018
@jemc jemc merged commit 6db1617 into master Mar 28, 2018
@jemc jemc deleted the antecedent-type-null branch March 28, 2018 19:46
ponylang-main added a commit that referenced this pull request Mar 28, 2018
dipinhora pushed a commit to dipinhora/ponyc that referenced this pull request Jun 5, 2018
Fix compiler crash related to array inference.
dipinhora pushed a commit to dipinhora/ponyc that referenced this pull request Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling fails with an ast != NULL failed` assertion when creating a Regex to String map
2 participants