Add SourceLoc.type_name method, showing the name of the containing type. #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemc
force-pushed
the
feature/source-loc-typ
branch
from
8bcdf42 to
d88cfb0
Compare
jemc
added
the
changelog - added
|
What do you think about using |
|
Or maybe |
|
If we use I'm okay with using |
|
I'd personally prefer |
|
Annoying for it to be a breaking change but, we are pre-1.0. I upvoted type_name and method_name. |
SourceLoc already shows the method name of the __loc object, but not the type name. Adding the type name is a logical next step, since it is available. The method is named typ, because type is a reserved keyword that cannot be used as a method name.
|
Okay, updated with the different name, and added a manual changelog entry. |
jemc
force-pushed
the
feature/source-loc-typ
branch
from
d88cfb0 to
7cbf92c
Compare
jemc
changed the title
jemc
removed
the
changelog - added
Praetonus
approved these changes
Apr 20, 2018
Closed
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
…pe. (ponylang#2643) * Add SourceLoc.typ method, showing the name of the containing type. SourceLoc already shows the method name of the __loc object, but not the type name. Adding the type name is a logical next step, since it is available. The method is named typ, because type is a reserved keyword that cannot be used as a method name. * Rename SourceLoc.{typ, method} as {type_name, method_name}. * Add manual changelog entry for PR ponylang#2643.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceLoc already shows the method name of the __loc object,
but not the type name. Adding the type name is a logical next step,
since it is available.
EDIT:
Also renames
methodasmethod_name.