Revert "Remove exception parameterisation from serialisation (#2524)" #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g#2524)" This reverts commit d34dce6. While performance testing the Pony version of Wallaroo's Market Spread application in a multi worker scenario, it was discovered that the above commit introduced a performance regression in both throughput and latency. This regression is not present in a single worker run where serialisation is not used. It should be noted that this regression only occurs when consuming messages at a maximum rate and is not present if the sending worker is not performing at maximum capacity. With this commit reverted, sending in messages at the same rate resulted in higher throughput and lower latencies. If an example application is needed to recreate this behavior we can provide instructions to run the Wallaroo application or attempt to create a minimal example.
|
It would be nice to have latency and throughput tests so performance regressions can be caught early. |
|
@Praetonus just heads up we are reverting this for now due to the "we arent sure why this caused a regression". |
sylvanc
approved these changes
Jun 6, 2018
Closed
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 7, 2018
[skip ci]
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 8, 2018
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d34dce6.
While performance testing the Pony version of Wallaroo's Market Spread
application in a multi worker scenario, it was discovered that the above
commit introduced a performance regression in both throughput and latency.
This regression is not present in a single worker run where serialisation
is not used. It should be noted that this regression only occurs when
consuming messages at a maximum rate and is not present if the sending
worker is not performing at maximum capacity. With this commit reverted,
sending in messages at the same rate resulted in higher throughput
and lower latencies.
If an example application is needed to recreate this behavior we can
provide instructions to run the Wallaroo application or attempt to
create a minimal example.