Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly allocate memory for linker arguments #2797

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Conversation

SeanTAllen
Copy link
Member

This was original brought up by @saolsen in PR #2694. This is a cleaned
up version of that PR based on feedback from @jemc.

This was original brought up by @saolsen in PR #2694. This is a cleaned
up version of that PR based on feedback from @jemc.
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Jun 17, 2018
@SeanTAllen SeanTAllen requested a review from jemc June 17, 2018 16:53
Copy link
Member

@jemc jemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we had some spurious CI failures.

I restarted those CI jobs that failed.

@SeanTAllen SeanTAllen merged commit 7d95171 into master Jun 18, 2018
@SeanTAllen SeanTAllen deleted the linker-args branch June 18, 2018 02:26
ponylang-main added a commit that referenced this pull request Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants