Add libexecinfo to debug builds for BSD #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slfritchie
added
bug: 4 - in progress
changelog - fixed
Closed
|
I hope the qemu based BSD ci tests work out. Doubtful though given when CI jobs time out. |
|
Merging to include in release 0.24.1. |
ponylang-main
added a commit
that referenced
this pull request
Jul 21, 2018
valpackett
added a commit
to valpackett/ponyc
that referenced
this pull request
Oct 17, 2018
ponylang#2826 restricted -lexecinfo to debug compilers (not even to building something in debug mode). This doesn't make much sense. I'm not sure why ordinary builds can succeed without -lexecinfo, but bitcode-runtime builds can't. Either way, if it's always included on non-glibc-Linux, it should always be included on BSD.
jemc
pushed a commit
that referenced
this pull request
Nov 2, 2018
#2826 restricted -lexecinfo to debug compilers (not even to building something in debug mode). This doesn't make much sense. I'm not sure why ordinary builds can succeed without -lexecinfo, but bitcode-runtime builds can't. Either way, if it's always included on non-glibc-Linux, it should always be included on BSD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #2823 for OpenBSD support and also #2825, I also tried twiddling a bit with FreeBSD and discovered that it isn't possible to compile with
config=debugsuccessfully. Runninggmake config=debug test verbose=trueon ponyc's tag0.24.0on both FreeBSD 11 + LLVM 3.9.1 and DragonflyBSD 4.8.1 + LLVM 3.9.1: