Fix validation of provides lists of object literals. #2860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously using a type alias pointing to a UNION type in the provides list of an object literal made the compiler assert.
fixes #2829
There is still a missing case where one would in general expect a compiler error, but nothing is thrown: Having a union of subtypes behind a type-alias:
By the time the object AST is resolved the union folding already kicked in, so
T1
only resolves toI1
, not a union anymore. I am unsure what to do about this. Is this really a case that we should care about?