Fix losing data when reading from STDIN. #2872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation fills the full underlying array based on the
"space" available.
However, the space may be larger than the chunk size since space is
allocated in powers of two. However, when the data buffer is passed back
via the InputNotify handle it is first appropriately truncated to the
actual
len
read by @pony_os_stdin_read. But, the implementation oftruncate sets the size to max(len, size) and does not take into account
the underlying allocated space.
The net result is that reading of stdin looses data unless the chunk
size provided is actually a power of two — in which case
_size == _alloc
.This change simply limits the read to
data.size()
rather thandata.space()
.Please see: #2871.