Make TCPConnection yield on writes to not hog cpu #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port over of the following PR from wallaroo: WallarooLabs/wally#2565 This commit adds a `_write_again` to the `TCPConnection` actor and modifies the `_pending_writes` function to yield by calling `_write_again` after having sent at least `_max_size` bytes. This will allow other actors and GC to run when a large amount of data has been queued up to be sent.
|
Can you add a CHANGELOG entry for this? |
SeanTAllen
approved these changes
Jun 9, 2019
|
@SeanTAllen changelog entry added. But it seems that my adding |
|
@dipinhora yeah, you'll need to rewrite to not have the [skip ci] |
|
@SeanTAllen |
patches11
pushed a commit
to patches11/ponyc
that referenced
this pull request
Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port over of the following PR from wallaroo:
WallarooLabs/wally#2565
This commit adds a
_write_againto theTCPConnectionactorand modifies the
_pending_writesfunction to yield by calling_write_againafter having sent at least_max_sizebytes.This will allow other actors and GC to run when a large amount
of data has been queued up to be sent.