Fix nested tuple access regression introduced by #3304 #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR ponylang#3304 introduced a bug that caused segfaults with nested tuple access. This commit resolves the issue and adds a test to prevent another regression. resolves ponylang#3354.
SeanTAllen
added
the
changelog - fixed
|
@EpicEric is this important enough to trigger a release or can it wait til the next scheduled release? |
|
Thanks, @dipinhora. |
It isn't. I've worked around the bug in my code. |
|
@dipinhora can you add release notes for this to #3363? |
jemc
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3304 introduced a bug that caused segfaults with nested tuple
access.
This commit resolves the issue and adds a test to prevent another
regression.
resolves #3354.