Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cli issue when providing --help=false. #3442

Merged
merged 1 commit into from
Jan 8, 2020
Merged

fix cli issue when providing --help=false. #3442

merged 1 commit into from
Jan 8, 2020

Conversation

mfelsche
Copy link
Contributor

@mfelsche mfelsche commented Jan 7, 2020

Fixes #3439

@mfelsche mfelsche requested a review from cquinn January 7, 2020 20:38
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Jan 7, 2020
cquinn
cquinn approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@cquinn cquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SeanTAllen SeanTAllen merged commit e1a6214 into master Jan 8, 2020
@SeanTAllen SeanTAllen deleted the cli-help-false branch January 8, 2020 00:04
github-actions bot pushed a commit that referenced this pull request Jan 8, 2020
@ponylang-main
Update CHANGELOG for PR #3442 [skip ci]
354a52a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquinn cquinn cquinn approved these changes

Assignees
No one assigned
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--help handling is odd with Command Parser
3 participants
@mfelsche @cquinn @SeanTAllen