Let processmonitor chdir before exec #3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and make the path primitives private, so they don't leak into the stdlib documentation.
…teBuf buffer write regression
- Windows stdin will turn '\n' into "\r\n"; make `process/STDIN-WriteBuf` test account for this. - Quote command-line args for passing to `CreateProcess()` on Windows
chalcolith
added
the
changelog - changed
|
Thanks @kulibali i somehowbmissed your rebase request. Also thank you very much for fixing the remaining windows issues. They kept me from making progress on this matter too. Totaly fine to merge, if ci is cooperative. |
mfelsche
approved these changes
Apr 30, 2020
SeanTAllen
added a commit
that referenced
this pull request
May 1, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have taken the liberty of rebasing #2981 (and fixing a couple of Windows issues) because I am too impatient to wait for @mfelsche to have time to look at it.
Quoth @rkallos:
Fixes #2821.
This PR adds a pipe for errors that take place after fork() and exec(), which might also solve #2719. Data sent across this pipe winds up calling ProcessNotify.stderr. This is disingenuous, since the data was actually sent along a separate pipe. However, it seems intuitive enough, as I imagine that is where error dispatch and handling would take place. I also did not want to inflict a large change on ProcessNotify without the blessing of the Pony core team. All in all, this seemed like the path of least resistance for fixing the issue. I would be happy to change the behavior to something else.