Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with expressions using tuple destructuring. #3586

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Fix with expressions using tuple destructuring. #3586

merged 1 commit into from
Jul 10, 2020

Conversation

mfelsche
Copy link
Contributor

@mfelsche mfelsche commented Jul 7, 2020

A with expression like the following caused the compiler to abort:

with (a, b) = some_tuple do
   error
end

This PR fixes those cases and adds some test coverage for desugaring with expressions in general.

Fixes #3581

@mfelsche mfelsche added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Jul 7, 2020
@SeanTAllen SeanTAllen requested a review from jemc July 8, 2020 00:48
@SeanTAllen
Copy link
Member

@jemc @kulibali I don't feel qualified to review this one, can either of you give it a look?

@jemc jemc merged commit c4685c1 into master Jul 10, 2020
@jemc jemc deleted the with-tuple-desttructuring branch July 10, 2020 15:23
github-actions bot pushed a commit that referenced this pull request Jul 10, 2020
@ponylang-main
Update CHANGELOG for PR #3586 [skip ci]
416de3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemc jemc jemc approved these changes

Assignees
No one assigned
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with tuple causes compiler to abort
3 participants
@mfelsche @SeanTAllen @jemc