Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prebuilt ponyc binaries for CentOS 8 #3629

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Add prebuilt ponyc binaries for CentOS 8 #3629

merged 1 commit into from
Aug 30, 2020

Conversation

SeanTAllen
Copy link
Member

@SeanTAllen SeanTAllen commented Aug 29, 2020 •
edited
Loading

At the request of Damon Kwok, we are adding prebuilt CentOS 8 versions
of ponyc. Both nightly and release builds.

@SeanTAllen
Add prebuilt ponyc binaries for CentOS 8
4595fa2 
At the request of Damon Kwok, we are adding prebuilt CentOS 8 versions
of ponyc. Both nightly and release builds.
@SeanTAllen SeanTAllen added the do not merge This PR should not be merged at this time label Aug 29, 2020
@SeanTAllen SeanTAllen marked this pull request as draft August 29, 2020 01:31
@SeanTAllen SeanTAllen force-pushed the centos8-builder branch 4 times, most recently from 4cc91db to 869bdd3 Compare August 29, 2020 04:05
@SeanTAllen SeanTAllen changed the title Testing centos building Add prebuilt ponyc binaries for CentOS 8 Aug 29, 2020
@SeanTAllen SeanTAllen requested review from EpicEric and Theodus August 29, 2020 04:06
@SeanTAllen SeanTAllen added changelog - added Automatically add "Added" CHANGELOG entry on merge and removed do not merge This PR should not be merged at this time labels Aug 29, 2020
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 3629.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen
Copy link
Member Author

@Theodus do we need to make a change to ponyup for these to show up?

@SeanTAllen SeanTAllen marked this pull request as ready for review August 29, 2020 04:07
@SeanTAllen SeanTAllen force-pushed the centos8-builder branch 2 times, most recently from 17d8449 to 4595fa2 Compare August 29, 2020 04:14
SeanTAllen
SeanTAllen commented Aug 29, 2020
View reviewed changes
.ci-dockerfiles/x86-64-unknown-linux-centos8-builder/Dockerfile

RUN yum install -y \
clang \
diffutils \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one blew me away. Not diff install by default.

.ci-dockerfiles/x86-64-unknown-linux-centos8-builder/Dockerfile
RUN yum install -y \
dnf-plugins-core \
epel-release \
&& yum config-manager --set-enabled PowerTools
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required in order to be able to get libstdc++-static

.ci-dockerfiles/x86-64-unknown-linux-centos8-builder/Dockerfile
&& pip3 install cloudsmith-cli

# install a newer cmake
RUN curl --output cmake-3.15.3-Linux-x86_64.sh https://cmake.org/files/v3.15/cmake-3.15.3-Linux-x86_64.sh \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The supplied version of cmake is too old.

.cirrus.yml
Comment on lines +240 to +241
TRIPLE_VENDOR: unknown
TRIPLE_OS: centos8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Theodus based on our Ubuntu18.04 naming, I believe this should be correct.

@SeanTAllen
Copy link
Member Author

SeanTAllen commented Aug 29, 2020 •
edited
Loading

I verified that:

  • ponyc builds and passes CI with this container
  • that the additional required tar for the release scripts is available in the container

Theodus
Theodus approved these changes Aug 30, 2020
View reviewed changes
Copy link
Contributor

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@SeanTAllen SeanTAllen merged commit d4c6497 into master Aug 30, 2020
@SeanTAllen SeanTAllen deleted the centos8-builder branch August 30, 2020 12:35
github-actions bot pushed a commit that referenced this pull request Aug 30, 2020
@ponylang-main
Updates release notes for PR #3629
0c2c07c
github-actions bot pushed a commit that referenced this pull request Aug 30, 2020
@ponylang-main
Update CHANGELOG for PR #3629
fdd9288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Theodus Theodus Theodus approved these changes

@EpicEric EpicEric Awaiting requested review from EpicEric

Assignees
No one assigned
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeanTAllen @ponylang-main @Theodus