Don't allow PONYPATH to override standard library #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
added
the
changelog - changed
Prior to this change, a library could contain a package called `builtin` that would override to standard library version. This could be an attack vector. You can still override the standard library location by using the ponyc `--paths` option. Any code which relied on the PONYPATH items being before the standard library in the package search path will need to switch to using `--paths` on the ponyc command line. Closes #3779
Theodus
approved these changes
Jul 6, 2021
ergl
approved these changes
Jul 6, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, a library could contain a package called
builtinthat would override to standard library version. This could be an attack
vector. You can still override the standard library location by using the
ponyc
--pathsoption.Any code which relied on the PONYPATH items being before the standard
library in the package search path will need to switch to using
--pathson the ponyc command line.
Closes #3779