Make FileMode._os public #3809
Merged
Make FileMode._os public #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
added
the
changelog - changed
chalcolith
approved these changes
Jul 17, 2021
FileMode has always had a private method for getting an integer representation of the file mode. However, it was private and only available for use within the `files` package. I discovered this when writing a pure pony tar library and needed exactly the functionality of _os. This commit changes `_os` from private to public as `os` and updates its callers.
jemc
reviewed
Jul 18, 2021
|
|
||
| FileMode has always had a private method for getting an integer representation of the file mode. However, it was private and only available for use within the `files` package. | ||
|
|
||
| It is now public as `FileMode.os`. |
There was a problem hiding this comment.
os is kind of a weird name for this - as a private method that didn't matter much, but now that it's public, it kind of does. I'd kind of expect os to return me something that tells what operating system the filesystem is running within, as little sense as that may make.
I might have preferred something else, though my night-weary brain is unsure what the right thing to call it would be. Maybe just u32?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileMode has always had a private method for getting an integer
representation of the file mode. However, it was private and only
available for use within the
filespackage.I discovered this when writing a pure pony tar library and needed
exactly the functionality of _os.
This commit changes
_osfrom private to public asosand updatesits callers.