Stop standalone libponyc from needing zlib #3827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we switched to LLVM 12, there was a 2nd def to set to off to avoid needing to be linked with zlib.
SeanTAllen
added
the
changelog - fixed
ergl
approved these changes
Aug 17, 2021
jemc
reviewed
Aug 17, 2021
| @@ -121,6 +121,7 @@ set(LLVM_INCLUDE_BENCHMARKS OFF) | |||
| set(LLVM_INCLUDE_TESTS OFF) | |||
| set(LLVM_TOOL_REMARKS_SHLIB_BUILD OFF) | |||
| set(LLVM_ENABLE_ZLIB OFF) | |||
| set(LVM_ENABLE_ZLIB:STRING OFF) | |||
There was a problem hiding this comment.
Why does it say LVM instead of LLVM?
There was a problem hiding this comment.
oops. and yet it still worked. will fix on main.
There was a problem hiding this comment.
i probably fat fingered on creating the PR. we need a test for this eventually, but it requires creating a program that gets linked and making sure it builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched to LLVM 12, there was a 2nd def to set to off to
avoid needing to be linked with zlib.