Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pony primitive that exposes scheduler information #3984

Merged
merged 6 commits into from
Feb 2, 2022

Conversation

SeanTAllen
Copy link
Member

@SeanTAllen SeanTAllen commented Feb 2, 2022

Previously, when users wanted to optimize the parallelizing work based on the maximum number of actors that can be run at a single time, we were pointing them to using the private runtime method @ponyint_sched_cores().

This was problematic for two reasons:

  1. We were pointing users at an internal implementation method that we hadn't promised not to change.
  2. We were requiring users to muck about with FFI for something that has become somewhat common for users wanting to maximize performance want to know.

We've now exposed some information about scheduler threads via a new package runtime_info thereby resolving both of the problems mentioned above.

Pony users should expect to see additional information added to the runtime_info package moving forward.

Anyone who was using the internal ponyint_sched_cores() FFI call will need to update to using runtime_info as ponyint_sched_cores() has been removed.

Closes #3985

@github-actions github-actions bot added the discuss during sync Should be discussed during an upcoming sync label Feb 2, 2022
@SeanTAllen SeanTAllen changed the title Expose max scheduler threads Add a pony primitive that exposes via Pony code information about the scheduler Feb 2, 2022
@SeanTAllen SeanTAllen added the changelog - added Automatically add "Added" CHANGELOG entry on merge label Feb 2, 2022
@SeanTAllen SeanTAllen marked this pull request as ready for review February 2, 2022 03:57
@SeanTAllen SeanTAllen changed the title Add a pony primitive that exposes via Pony code information about the scheduler Add a pony primitive that exposes scheduler information Feb 2, 2022
@SeanTAllen
Copy link
Member Author

When this is merged, it should be noted in last week in pony that RFC 71 has been implemented.

@SeanTAllen SeanTAllen merged commit 2f1e7c9 into main Feb 2, 2022
@SeanTAllen SeanTAllen deleted the expose-max-scheduler-threads branch February 2, 2022 13:19
@github-actions github-actions bot removed the discuss during sync Should be discussed during an upcoming sync label Feb 2, 2022
github-actions bot pushed a commit that referenced this pull request Feb 2, 2022
github-actions bot pushed a commit that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC #71: Expose scheduler thread information in standard library
2 participants