Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "prevent non-opaque structs from being used as behaviour parameters" #3995

Merged
merged 3 commits into from
Feb 5, 2022

Conversation

SeanTAllen
Copy link
Member

@SeanTAllen SeanTAllen commented Feb 5, 2022

The bug that #3781 aka "prevent non-opaque structs from being used as behaviour parameters" was an attempt at preventing, as only partially solved by the change.

We've introduced a full fix in #3993 that removes the need for #3871.

With the merging of #3993, the changes from #3781 are no longer needed.
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 5, 2022
@SeanTAllen SeanTAllen changed the title Revert 3781 Revert "prevent non-opaque structs from being used as behaviour parameters" Feb 5, 2022
@SeanTAllen SeanTAllen added the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label Feb 5, 2022
@SeanTAllen SeanTAllen marked this pull request as ready for review February 5, 2022 01:15
@SeanTAllen SeanTAllen requested a review from a team February 5, 2022 01:15
@SeanTAllen SeanTAllen merged commit cee12b9 into main Feb 5, 2022
@SeanTAllen SeanTAllen deleted the revert-3781 branch February 5, 2022 13:14
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 5, 2022
github-actions bot pushed a commit that referenced this pull request Feb 5, 2022
github-actions bot pushed a commit that referenced this pull request Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants