Fix parameter names not being checked #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponylang-main
added
the
discuss during sync
SeanTAllen
commented
Mar 19, 2022
Comment on lines
+648
to
+664
| const char* bad5 = | ||
| "trait Foo\n" | ||
| " fun foo(_x: U64) => 3"; | ||
|
|
||
| TEST_ERROR(bad5); | ||
|
|
||
| const char* bad5_be = | ||
| "trait Foo\n" | ||
| " be foo(_x: U64) => 3"; | ||
|
|
||
| TEST_ERROR(bad5_be); | ||
|
|
||
| const char* bad5_new = | ||
| "class Foo\n" | ||
| " new create(_x: U64) => 3"; | ||
|
|
||
| TEST_ERROR(bad5_new); |
There was a problem hiding this comment.
We used to have a test for this being allowed, however, under the rules it shouldnt be allowed. It was only allowed at some point because you could use _ in case method parameters. Otherwise it was supposed to be illegal.
SeanTAllen
commented
Mar 19, 2022
| @@ -553,31 +553,115 @@ TEST_F(SugarTest, FunctionNoReturnBody) | |||
| } | |||
|
|
|||
|
|
|||
| TEST_F(SugarTest, FunctionParamMustBeId) | |||
| TEST_F(SugarTest, MethodParamMustBeId) | |||
There was a problem hiding this comment.
because we check parameter names after sugaring be, fun, and new, i updated the tests to check for each type as it would otherwise be possible to break for say be because we were only checking fun.
accordingly, the test name was updated.
SeanTAllen
added
the
changelog - fixed
jemc
approved these changes
Mar 19, 2022
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2018, when we removed case functions from Pony, we also removed the checking to make sure that parameters names were valid.
We've added checking of parameter names to make sure they match the naming rules for parameters in Pony.
Fixes #4054